Refactor WS code building raw http_response objects

Both ws_handshake_reply and ws_reply build http_response objects without
using the status code or headers, this code can be refactored to use a
single method.

src/http.c

@@ -16,6 +16,10 @@ http_response_init(struct worker *w, int code, const char *msg) {
 
 	/* create object */
 	struct http_response *r = calloc(1, sizeof(struct http_response));
+	if(!r) {
+		if(w && w->s) slog(w->s, WEBDIS_ERROR, "Failed to allocate http_response", 0);
+		return NULL;
+	}
 
 	r->code = code;
 	r->msg = msg;
@@ -43,6 +47,24 @@ http_response_init(struct worker *w, int code, const char *msg) {
 	return r;
 }
 
+struct http_response *
+http_response_init_with_buffer(struct worker *w, char *data, size_t data_sz, int keep_alive) {
+
+	struct http_response *r = calloc(1, sizeof(struct http_response));
+	if(!r) {
+		if(w && w->s) slog(w->s, WEBDIS_ERROR, "Failed to allocate http_response with buffer", 0);
+		return NULL;
+	}
+	r->w = w;
+
+	/* provide buffer directly */
+	r->out = data;
+	r->out_sz = data_sz;
+	r->sent = 0;
+	r->keep_alive = keep_alive;
+	return r;
+}
+
 
 void
 http_response_set_header(struct http_response *r, const char *k, const char *v) {

src/http.h

@@ -45,6 +45,9 @@ struct http_response {
 struct http_response *
 http_response_init(struct worker *w, int code, const char *msg);
 
+struct http_response *
+http_response_init_with_buffer(struct worker *w, char *data, size_t data_sz, int keep_alive);
+
 void
 http_response_set_header(struct http_response *r, const char *k, const char *v);
 

src/websocket.c

@@ -172,17 +172,13 @@ ws_handshake_reply(struct http_client *c) {
 	p += sizeof(template_end)-1;
 
 	/* build HTTP response object by hand, since we have the full response already */
-	struct http_response *r = calloc(1, sizeof(struct http_response));
+	struct http_response *r = http_response_init_with_buffer(c->w, buffer, sz, 1);
 	if(!r) {
 		slog(c->s, WEBDIS_ERROR, "Failed to allocate response for WS handshake", 0);
 		free(buffer);
 		return -1;
 	}
-	r->w = c->w;
+
-	r->keep_alive = 1;
-	r->out = buffer;
-	r->out_sz = sz;
-	r->sent = 0;
 	http_schedule_write(c->fd, r); /* will free buffer and response once sent */
 
 	return 0;
@@ -386,20 +382,15 @@ ws_reply(struct cmd *cmd, const char *p, size_t sz) {
 		frame_sz = sz + 10;
 	}
 
-	/* send WS frame */
+	/* mark as keep alive, otherwise we'll close the connection after the first reply */
-	r = http_response_init(cmd->w, 0, NULL);
+	r = http_response_init_with_buffer(cmd->w, frame, frame_sz, 1);
 	if (r == NULL) {
 		free(frame);
 		slog(cmd->w->s, WEBDIS_ERROR, "Failed response allocation in ws_reply", 0);
 		return -1;
 	}
 
-	/* mark as keep alive, otherwise we'll close the connection after the first reply */
+	/* send WS frame */
-	r->keep_alive = 1;
-
-	r->out = frame;
-	r->out_sz = frame_sz;
-	r->sent = 0;
 	http_schedule_write(cmd->fd, r);
 
 	return 0;