Merge pull request #883 from rqlite/missing-http-returns

Add missing returns after HTTP errors

CHANGELOG.md

@@ -1,6 +1,7 @@
 ## 6.4.3 (unreleased)
 ### Implementation changes and bug fixes
 - [PR #882](https://github.com/rqlite/rqlite/pull/882): Some minor improvements related to on-disk SQLite use.
+- [PR #883](https://github.com/rqlite/rqlite/pull/883): Add missing returns after HTTP errors.
 
 ## 6.4.2 (September 1st 2021)
 ### Implementation changes and bug fixes

http/service.go

@@ -632,13 +632,13 @@ func (s *Service) handleStatus(w http.ResponseWriter, r *http.Request) {
 	}
 	if err != nil {
 		http.Error(w, err.Error(), http.StatusInternalServerError)
-	} else {
+		return
+	}
 	_, err = w.Write([]byte(b))
 	if err != nil {
 		http.Error(w, err.Error(), http.StatusInternalServerError)
 		return
 	}
-	}
 }
 
 // handleNodes returns status on the other voting nodes in the system.
@@ -725,13 +725,13 @@ func (s *Service) handleNodes(w http.ResponseWriter, r *http.Request) {
 	}
 	if err != nil {
 		http.Error(w, err.Error(), http.StatusInternalServerError)
-	} else {
+		return
+	}
 	_, err = w.Write([]byte(b))
 	if err != nil {
 		http.Error(w, err.Error(), http.StatusInternalServerError)
 		return
 	}
-	}
 }
 
 // handleExecute handles queries that modify the database.
@@ -794,10 +794,12 @@ func (s *Service) handleExecute(w http.ResponseWriter, r *http.Request) {
 		addr, err := s.store.LeaderAddr()
 		if err != nil {
 			http.Error(w, err.Error(), http.StatusInternalServerError)
+			return
 		}
 		if addr == "" {
 			stats.Add(numLeaderNotFound, 1)
 			http.Error(w, ErrLeaderNotFound.Error(), http.StatusServiceUnavailable)
+			return
 		}
 		results, resultsErr = s.cluster.Execute(er, addr, timeout)
 		stats.Add(numRemoteExecutions, 1)
@@ -881,10 +883,12 @@ func (s *Service) handleQuery(w http.ResponseWriter, r *http.Request) {
 		addr, err := s.store.LeaderAddr()
 		if err != nil {
 			http.Error(w, err.Error(), http.StatusInternalServerError)
+			return
 		}
 		if addr == "" {
 			stats.Add(numLeaderNotFound, 1)
 			http.Error(w, ErrLeaderNotFound.Error(), http.StatusServiceUnavailable)
+			return
 		}
 		results, resultsErr = s.cluster.Query(qr, addr, timeout)
 		stats.Add(numRemoteQueries, 1)