From 4c11ac7b6601bd0b5a9157bee56b50493ea12757 Mon Sep 17 00:00:00 2001 From: Sayan Nandan Date: Sun, 31 Mar 2024 11:41:03 +0530 Subject: [PATCH] DCL: further test for empty authentication data --- CHANGELOG.md | 10 ++++++++-- server/src/engine/tests/client_misc/sec/mod.rs | 18 ++++++++++++++++++ 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f02ab680..e236e454 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,8 +10,14 @@ All changes in this project will be noted in this file. ### Fixes -- Fixed migration from v1 SE (released with v0.8.0-beta) to v2 SE (released in v0.8.0) -- Fixed health reporting +- **Server**: + - Fixed migration from v1 SE (released with v0.8.0-beta) to v2 SE (released in v0.8.0) + - Fixed health reporting + - Fixed a connection crash (not a server-wide crash) at the pre-connection stage when authentication data + was sent incorrectly +- **CLI**: + - Fixed `--eval` output. All server errors are now correctly written to `stderr` + - Guard against empty passwords ## Version 0.8.0 diff --git a/server/src/engine/tests/client_misc/sec/mod.rs b/server/src/engine/tests/client_misc/sec/mod.rs index 824e5666..ff3df078 100644 --- a/server/src/engine/tests/client_misc/sec/mod.rs +++ b/server/src/engine/tests/client_misc/sec/mod.rs @@ -64,3 +64,21 @@ fn ensure_empty_password_returns_hs_error_5() { Error::ConnectionSetupErr(ConnectionSetupError::HandshakeError(5)) ); } + +#[dbtest(username = "", password = "1234567890")] +fn ensure_empty_username_returns_hs_error_5() { + let db = db_connect!(); + assert_err_eq!( + db, + Error::ConnectionSetupErr(ConnectionSetupError::HandshakeError(5)) + ); +} + +#[dbtest(username = "", password = "")] +fn ensure_empty_username_and_password_returns_hs_error_5() { + let db = db_connect!(); + assert_err_eq!( + db, + Error::ConnectionSetupErr(ConnectionSetupError::HandshakeError(5)) + ); +}