Merge pull request #1608 from rqlite/release-the-snap

Always close the FSM Snapshot

CHANGELOG.md

@@ -1,6 +1,7 @@
 ## 8.16.7 (unreleased)
 ### Implementation changes and bug fixes
 - [PR #1607](https://github.com/rqlite/rqlite/pull/1607): Remove use of deprecated `ioutil`.
+- [PR #1608](https://github.com/rqlite/rqlite/pull/1608): Always close the FSM Snapshot.
 
 ## 8.16.6 (January 16th 2024)
 ### Implementation changes and bug fixes

snapshot/snapshot.go

@@ -48,4 +48,7 @@ func (s *Snapshot) Persist(sink raft.SnapshotSink) error {
 }
 
 // Release releases the snapshot.
-func (s *Snapshot) Release() {}
+func (s *Snapshot) Release() {
+	// Necessary in case Persist() is never called.
+	s.rc.Close()
+}