1
0
Fork 0

Merge pull request #1663 from rqlite/defer-wal-close-only

Use defer only to make sure WAL file is closed
master
Philip O'Toole 8 months ago committed by GitHub
commit b8c5921255
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

@ -1946,7 +1946,7 @@ func (s *Store) fsmSnapshot() (fSnap raft.FSMSnapshot, retErr error) {
if err != nil {
return nil, err
}
defer walFD.Close() // Make sure it closes.
defer walFD.Close()
scanner, err := wal.NewFastCompactingScanner(walFD)
if err != nil {
return nil, err
@ -1955,8 +1955,6 @@ func (s *Store) fsmSnapshot() (fSnap raft.FSMSnapshot, retErr error) {
if err != nil {
return nil, err
}
walFD.Close() // We need it closed before truncating it.
stats.Get(snapshotCreateWALCompactDuration).(*expvar.Int).Set(time.Since(compactStartTime).Milliseconds())
compactedBuf = bytes.NewBuffer(compactedBytes)

Loading…
Cancel
Save