1
0
Fork 0

Move NextProtos to server TLS config only

master
Philip O'Toole 10 months ago
parent 60faad15e7
commit b08cec64a1

@ -385,7 +385,6 @@ func getHTTPClient(argv *argT) (*http.Client, error) {
if err != nil {
return nil, err
}
tlsConfig.NextProtos = nil // CLI refuses to connect otherwise.
client := http.Client{
Transport: &http.Transport{
@ -441,7 +440,6 @@ func sendRequest(ctx *cli.Context, makeNewRequest func(string) (*http.Request, e
if err != nil {
return nil, err
}
tlsConfig.NextProtos = nil // CLI refuses to connect otherwise.
client := http.Client{Transport: &http.Transport{
TLSClientConfig: tlsConfig,
Proxy: http.ProxyFromEnvironment,

@ -86,13 +86,12 @@ func CreateClientConfig(certFile, keyFile, caCertFile string, noverify bool) (*t
// parameters are the paths to the server's certificate and key files, which will be used to
// authenticate the server to the client. The caCertFile parameter is the path to the CA
// certificate file, which the server will use to verify any certificate presented by the
// client. If noverify is true, the server will not verify the client's certificate. If
// tls1011 is true, the server will accept TLS 1.0 or 1.1. Otherwise, it will require TLS 1.2
// or higher.
// client. If noverify is true, the server will not verify the client's certificate.
func CreateServerConfig(certFile, keyFile, caCertFile string, noverify bool) (*tls.Config, error) {
var err error
config := createBaseTLSConfig(false)
config.NextProtos = []string{"h2", "http/1.1"}
config.Certificates = make([]tls.Certificate, 1)
config.Certificates[0], err = tls.LoadX509KeyPair(certFile, keyFile)
if err != nil {
@ -118,7 +117,6 @@ func CreateServerConfig(certFile, keyFile, caCertFile string, noverify bool) (*t
func createBaseTLSConfig(noverify bool) *tls.Config {
return &tls.Config{
InsecureSkipVerify: noverify,
NextProtos: []string{"h2", "http/1.1"},
MinVersion: uint16(tls.VersionTLS12),
}
}

Loading…
Cancel
Save