From ade1ffdeef6319a4d53c4743fb85be2df7cf9723 Mon Sep 17 00:00:00 2001
From: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Date: Fri, 2 Feb 2024 19:56:14 -0300
Subject: [PATCH] use t.Run for query param tests

---
 http/service_test.go | 48 ++++++++++++++++++++++++++++----------------
 1 file changed, 31 insertions(+), 17 deletions(-)

diff --git a/http/service_test.go b/http/service_test.go
index 2137fbe4..bd5239f5 100644
--- a/http/service_test.go
+++ b/http/service_test.go
@@ -1318,38 +1318,52 @@ func Test_timeoutVersionPrettyQueryParam(t *testing.T) {
 
 func Test_DBTimeoutQueryParam(t *testing.T) {
 	tests := []struct {
-		url  string
-		want time.Duration
+		name    string
+		url     string
+		want    time.Duration
+		wantErr bool
 	}{
 		{
+			name: "1s",
 			url:  "http://localhost:4001/execute?db_timeout=1s",
 			want: 1 * time.Second,
 		},
 		{
+			name: "100ms",
 			url:  "http://localhost:4001/execute?db_timeout=100ms",
 			want: 100 * time.Millisecond,
 		},
 		{
-			url:  "http://localhost:4001/execute?db_timeout=xyz",
+			name: "default value",
+			url:  "http://localhost:4001/execute",
 			want: 0,
 		},
+		{
+			name:    "parse error",
+			url:     "http://localhost:4001/execute?db_timeout=xyz",
+			wantErr: true,
+		},
 	}
 
-	for i, tt := range tests {
-		mustURLParse(tt.url)
-		req, err := http.NewRequest("GET", tt.url, nil)
-		if err != nil {
-			t.Fatalf("failed to create request: %s", err)
-		}
-		qp, err := NewQueryParams(req)
-		if err != nil {
-			t.Fatalf(" unexpectedly failed to parse query params on test %d: %s", i, err)
-		}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			mustURLParse(tt.url)
+			req, err := http.NewRequest("GET", tt.url, nil)
+			if err != nil {
+				t.Fatalf("failed to create request: %s", err)
+			}
+			qp, err := NewQueryParams(req)
+			if err != nil {
+				if !tt.wantErr {
+					t.Fatalf("failed to create request: %s", err)
+				}
+			}
 
-		got := qp.DBTimeout(0)
-		if got != tt.want {
-			t.Fatalf("want %d, got %d", tt.want, got)
-		}
+			got := qp.DBTimeout(0)
+			if got != tt.want {
+				t.Fatalf("want %d, got %d", tt.want, got)
+			}
+		})
 	}
 }