From aa9eb9a8f42a1549a92665a9cb8b690879165c59 Mon Sep 17 00:00:00 2001 From: Philip O'Toole Date: Wed, 24 Nov 2021 21:41:17 -0500 Subject: [PATCH 1/3] Actually remove race job --- .circleci/config.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 83271198..ca585c4a 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -47,5 +47,4 @@ workflows: build_and_test: jobs: - test - - race - end_to_end From 03698f4598fb9d695066288b7e26faa604788495 Mon Sep 17 00:00:00 2001 From: Philip O'Toole Date: Fri, 26 Nov 2021 09:17:17 -0500 Subject: [PATCH 2/3] Reinstate race testing --- .circleci/config.yml | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index ca585c4a..cd1e2cb1 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -28,6 +28,33 @@ jobs: - run: go vet - run: go test ./... + race: + docker: + # specify the version + - image: circleci/golang@sha256:bf91f089cecab7fcd329193022794e7d13c42ee4570b1ac2920875c1b948eb63 + + # Specify service dependencies here if necessary + # CircleCI maintains a library of pre-built images + # documented at https://circleci.com/docs/2.0/circleci-images/ + # - image: circleci/postgres:9.4 + + #### TEMPLATE_NOTE: go expects specific checkout path representing url + #### expecting it in the form of + #### /go/src/github.com/circleci/go-tool + #### /go/src/bitbucket.org/circleci/go-tool + working_directory: /go/src/github.com/rqlite/rqlite + steps: + - checkout + + # specify any bash command here prefixed with `run: ` + # BoltDB, no longer maintained, has pointer issues. However it's run + # for years without actual issue so disabling the pointer tests + - run: go get -v -t -d ./... + - run: + command: go test -timeout 20m -gcflags=all=-d=checkptr=0 -race ./... + environment: + GORACE: "halt_on_error=1" + end_to_end: working_directory: /go/src/github.com/rqlite/rqlite docker: @@ -47,4 +74,5 @@ workflows: build_and_test: jobs: - test + - race - end_to_end From a7ddad2624ff63d974a4c55d0b89cdfa0100a63b Mon Sep 17 00:00:00 2001 From: Philip O'Toole Date: Fri, 26 Nov 2021 09:32:13 -0500 Subject: [PATCH 3/3] Update config.yml --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index cd1e2cb1..7c18a5dd 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -51,7 +51,7 @@ jobs: # for years without actual issue so disabling the pointer tests - run: go get -v -t -d ./... - run: - command: go test -timeout 20m -gcflags=all=-d=checkptr=0 -race ./... + command: go test -v -timeout 20m -gcflags=all=-d=checkptr=0 -race ./... environment: GORACE: "halt_on_error=1"